Make gcp_managed_network_config optional #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
reviewed
Jun 8, 2022
| @@ -67,7 +67,7 @@ type GCPCommonNetworkConfig struct { | |||
|
|
|||
| type GCPNetwork struct { | |||
| NetworkID string `json:"network_id,omitempty"` | |||
| GCPManagedNetworkConfig *GCPManagedNetworkConfig `json:"gcp_managed_network_config"` | |||
| GCPManagedNetworkConfig *GCPManagedNetworkConfig `json:"gcp_managed_network_config,omitempty"` | |||
| GCPCommonNetworkConfig *GCPCommonNetworkConfig `json:"gcp_common_network_config"` | |||
There was a problem hiding this comment.
what about the other network? :)
There was a problem hiding this comment.
gcp_common_network_config is still required AFAIK.
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
=========================================
Coverage ? 90.15%
=========================================
Files ? 124
Lines ? 10179
Branches ? 0
=========================================
Hits ? 9177
Misses ? 638
Partials ? 364
|
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1360 we added the
network_idparameter toGCPNetwork. If it is specified,gcp_managed_network_configis optional and ignored by the backend.